
GITHUB . COM {
}
Detected CMS Systems:
- Wordpress (2 occurrences)
Title:
1.9.1 breaks backward compatibility Β· Issue #4106 Β· pydantic/pydantic
Description:
Checks I added a descriptive title to this issue I have searched (google, github) for similar issues and couldn't find anything I have read and followed the docs and still think this is a bug B...
Website Age:
17 years and 8 months (reg. 2007-10-09).
Matching Content Categories {π}
- News & Politics
- Technology & Computing
- Dating & Relationships
Content Management System {π}
What CMS is github.com built with?
Github.com relies on WORDPRESS.
Traffic Estimate {π}
What is the average monthly size of github.com audience?
ππ Tremendous Traffic: 10M - 20M visitors per month
Based on our best estimate, this website will receive around 10,653,731 visitors per month in the current month.
check SE Ranking
check Ahrefs
check Similarweb
check Ubersuggest
check Semrush
How Does Github.com Make Money? {πΈ}
Subscription Packages {π³}
We've located a dedicated page on github.com that might include details about subscription plans or recurring payments. We identified it based on the word pricing in one of its internal links. Below, you'll find additional estimates for its monthly recurring revenues.How Much Does Github.com Make? {π°}
Subscription Packages {π³}
Prices on github.com are in US Dollars ($).
They range from $4.00/month to $21.00/month.
We estimate that the site has approximately 5,316,083 paying customers.
The estimated monthly recurring revenue (MRR) is $22,327,549.
The estimated annual recurring revenues (ARR) are $267,930,588.
Wordpress Themes and Plugins {π¨}
What WordPress theme does this site use?
It is strange but we were not able to detect any theme on the page.
What WordPress plugins does this website use?
It is strange but we were not able to detect any plugins on the page.
Keywords {π}
pydantic, issue, bug, change, sign, backward, pvicente, added, add, fix, samuelcolvin, breaks, compatibility, github, version, mentioned, eigenein, require, hramezani, commented, navigation, issues, pull, requests, actions, security, closed, docs, python, clang, mypy, complaining, patch, str, related, commit, references, member, breaking, prettywood, log, type, projects, milestone, footer, skip, content, menu, product, solutions,
Topics {βοΈ}
/users/pedrovicente/cytora/risk-stream-service/ completed hramezani mentioned venv/lib/python3 matches argument types comment metadata assignees pvicente mentioned similar issues add breaking change add breaking change samuelcolvin closed pydantic version pydantic v1 backward compatible docs fix issue import pydantic model = pydantic change log add cls_kwargs={} added descriptive title ['email-validator' 'typing-extensions'] field_definitions kwargs __module__=__name__ overload variant regression compared update history projects milestone milestone relationships personal information 1 tuple[type type projects issue pydantic python v1 dict[str github patch add change fix type sign str skip jump searched google
Payment Methods {π}
- Braintree
Questions {β}
- @samuelcolvin shall we add **Breaking Change in the change of 42acd8f as well?
- Already have an account?
Schema {πΊοΈ}
DiscussionForumPosting:
context:https://schema.org
headline:1.9.1 breaks backward compatibility
articleBody:### Checks
* [X] I added a descriptive title to this issue
* [X] I have searched (google, github) for similar issues and couldn't find anything
* [X] I have read and followed [the docs](https://pydantic-docs.helpmanual.io/) and still think this is a bug
<!-- Sorry to sound so draconian, but every second saved replying to issues is time spend improving pydantic :-) -->
# Bug
Output of `python -c "import pydantic.utils; print(pydantic.utils.version_info())"`:
```
pydantic version: 1.9.1
pydantic compiled: True
install path: /Users/pedrovicente/cytora/risk-stream-service/.venv/lib/python3.9/site-packages/pydantic
python version: 3.9.11 (main, May 4 2022, 15:54:04) [Clang 13.1.6 (clang-1316.0.21.2.3)]
platform: macOS-12.3.1-arm64-arm-64bit
optional deps. installed: ['email-validator', 'typing-extensions']
...
```
<!-- or if you're using pydantic prior to v1.3, manually include: OS, python version and pydantic version -->
<!-- Please read the [docs](https://pydantic-docs.helpmanual.io/) and search through issues to
confirm your bug hasn't already been reported. -->
#3713 [PR](https://github.com/samuelcolvin/pydantic/pull/3713/files#r878228704) breaks backward compatibility.
I think it should have been released as 2.0 and not as 1.9.1.
No matter it has a default value because there are **field_definitions** kwargs after it. Mypy was complaining and I had to add cls_kwargs={}, when calling it after updating from 1.9.0 to 1.9.1, so the change is not backward compatible and shouldn't have been a semver patch version release.
<!-- Where possible please include a self-contained code snippet describing your bug: -->
```py
model = pydantic.create_model(
model_name,
__config__=None,
__base__=None,
__module__=__name__,
__validators__={},
**{k: (v, ...) for k, v in attributes.items()},
...
```
After upgrade from 1.9.0 to 1.9.1 mypy is complaining with:
```
error: No overload variant of "create_model" matches argument types "str", "None", "None", "str", "Dict[<nothing>, <nothing>]", "Dict[str, Tuple[type, ellipsis]]"
```
author:
url:https://github.com/pvicente
type:Person
name:pvicente
datePublished:2022-05-23T08:32:29.000Z
interactionStatistic:
type:InteractionCounter
interactionType:https://schema.org/CommentAction
userInteractionCount:3
url:https://github.com/4106/pydantic/issues/4106
context:https://schema.org
headline:1.9.1 breaks backward compatibility
articleBody:### Checks
* [X] I added a descriptive title to this issue
* [X] I have searched (google, github) for similar issues and couldn't find anything
* [X] I have read and followed [the docs](https://pydantic-docs.helpmanual.io/) and still think this is a bug
<!-- Sorry to sound so draconian, but every second saved replying to issues is time spend improving pydantic :-) -->
# Bug
Output of `python -c "import pydantic.utils; print(pydantic.utils.version_info())"`:
```
pydantic version: 1.9.1
pydantic compiled: True
install path: /Users/pedrovicente/cytora/risk-stream-service/.venv/lib/python3.9/site-packages/pydantic
python version: 3.9.11 (main, May 4 2022, 15:54:04) [Clang 13.1.6 (clang-1316.0.21.2.3)]
platform: macOS-12.3.1-arm64-arm-64bit
optional deps. installed: ['email-validator', 'typing-extensions']
...
```
<!-- or if you're using pydantic prior to v1.3, manually include: OS, python version and pydantic version -->
<!-- Please read the [docs](https://pydantic-docs.helpmanual.io/) and search through issues to
confirm your bug hasn't already been reported. -->
#3713 [PR](https://github.com/samuelcolvin/pydantic/pull/3713/files#r878228704) breaks backward compatibility.
I think it should have been released as 2.0 and not as 1.9.1.
No matter it has a default value because there are **field_definitions** kwargs after it. Mypy was complaining and I had to add cls_kwargs={}, when calling it after updating from 1.9.0 to 1.9.1, so the change is not backward compatible and shouldn't have been a semver patch version release.
<!-- Where possible please include a self-contained code snippet describing your bug: -->
```py
model = pydantic.create_model(
model_name,
__config__=None,
__base__=None,
__module__=__name__,
__validators__={},
**{k: (v, ...) for k, v in attributes.items()},
...
```
After upgrade from 1.9.0 to 1.9.1 mypy is complaining with:
```
error: No overload variant of "create_model" matches argument types "str", "None", "None", "str", "Dict[<nothing>, <nothing>]", "Dict[str, Tuple[type, ellipsis]]"
```
author:
url:https://github.com/pvicente
type:Person
name:pvicente
datePublished:2022-05-23T08:32:29.000Z
interactionStatistic:
type:InteractionCounter
interactionType:https://schema.org/CommentAction
userInteractionCount:3
url:https://github.com/4106/pydantic/issues/4106
Person:
url:https://github.com/pvicente
name:pvicente
url:https://github.com/pvicente
name:pvicente
InteractionCounter:
interactionType:https://schema.org/CommentAction
userInteractionCount:3
interactionType:https://schema.org/CommentAction
userInteractionCount:3
External Links {π}(3)
Analytics and Tracking {π}
- Site Verification - Google
Libraries {π}
- Clipboard.js
- D3.js
- Lodash
Emails and Hosting {βοΈ}
Mail Servers:
- aspmx.l.google.com
- alt1.aspmx.l.google.com
- alt2.aspmx.l.google.com
- alt3.aspmx.l.google.com
- alt4.aspmx.l.google.com
Name Servers:
- dns1.p08.nsone.net
- dns2.p08.nsone.net
- dns3.p08.nsone.net
- dns4.p08.nsone.net
- ns-1283.awsdns-32.org
- ns-1707.awsdns-21.co.uk
- ns-421.awsdns-52.com
- ns-520.awsdns-01.net